Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: catalog source image #1552

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Conversation

saumeya
Copy link
Collaborator

@saumeya saumeya commented Oct 1, 2024

What type of PR is this?

/kind bug

What does this PR do / why we need it:
Fixes the incorrect catalog image that points to an invalid argocd-operator image

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?

How to test changes / Special notes to the reviewer:

Didn't rebuild the bundle, as the current bundle is updated for 0.13 (next) release.
Checked manual installation and works well.

@saumeya saumeya requested a review from svghadi October 1, 2024 17:03
@saumeya
Copy link
Collaborator Author

saumeya commented Oct 1, 2024

Should we have a test in the CI to check for olm installation of the operator? if that is possible to add @varshab1210 - these are the steps - https://argocd-operator.readthedocs.io/en/latest/install/olm/

@svghadi
Copy link
Collaborator

svghadi commented Oct 3, 2024

That's a great idea. Once we automate the release, we could set up a post-release job to verify the installations.

Copy link
Collaborator

@svghadi svghadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svghadi svghadi merged commit 14032c7 into argoproj-labs:master Oct 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants