Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning and send events if key and certificate used for route TLS configuration #1580

Merged
merged 7 commits into from
Oct 31, 2024

Conversation

anandrkskd
Copy link
Contributor

What type of PR is this?

/kind chore
What does this PR do / why we need it:
This PR sends event if insecure fields key and certificates are used for route TLS configuration also adds warning in logs for the same.

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes GITOPS-5517

How to test changes / Special notes to the reviewer:

  • run make install run on an OpenShift cluster
  • apply the below
apiVersion: argoproj.io/v1beta1
kind: ArgoCD
metadata:
  name: example-argocd
  labels:
    example: repo
spec:
  server:
    route: 
      enabled: true
      tls: 
        certificate: "Y2VydGlmY2F0ZQ=="
        key: "cHJpdmF0ZS1rZXk="
        insecureEdgeTerminationPolicy: Redirect
        termination: reencrypt
  • check for event created and logs

Copy link
Collaborator

@svghadi svghadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a few nits.

controllers/argocd/route.go Outdated Show resolved Hide resolved
controllers/argocd/route.go Outdated Show resolved Hide resolved
anandrkskd and others added 2 commits October 30, 2024 09:54
Signed-off-by: Anand Kumar Singh <[email protected]>
Signed-off-by: Siddhesh Ghadi <[email protected]>
Copy link
Collaborator

@svghadi svghadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @anandrkskd.

@svghadi svghadi merged commit c658393 into argoproj-labs:master Oct 31, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants