Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for image override for argocd-extension #1590

Merged

Conversation

anandrkskd
Copy link
Contributor

What type of PR is this?

/kind enhancement

What does this PR do / why we need it:
This PR adds downstream support of argocd-extension in gitops-operator using env var
Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes GITOPS-5661

How to test changes / Special notes to the reviewer:

@svghadi
Copy link
Collaborator

svghadi commented Nov 4, 2024

Looks like the new unit test is failing

--- FAIL: Test_getRolloutInitContainer (0.00s)
    --- FAIL: Test_getRolloutInitContainer/when_running_in_gitops#01 (0.00s)
        deployment_test.go:2448: 
            	Error Trace:	/home/runner/work/argocd-operator/argocd-operator/controllers/argocd/deployment_test.go:2448
            	Error:      	Not equal: 
            	            	expected: "quay.io/argoprojlabs/argocd-extension-installer:v0.0.8"
            	            	actual  : "updated_container"
            	            	
            	            	Diff:
            	            	--- Expected
            	            	+++ Actual
            	            	@@ -1 +1 @@
            	            	-quay.io/argoprojlabs/argocd-extension-installer:v0.0.8
            	            	+updated_container
            	Test:       	Test_getRolloutInitContainer/when_running_in_gitops#01
            	Messages:   	Image check
        deployment_test.go:2449: 
            	Error Trace:	/home/runner/work/argocd-operator/argocd-operator/controllers/argocd/deployment_test.go:2449
            	Error:      	Not equal: 
            	            	expected: []v1.EnvVar{v1.EnvVar{Name:"EXTENSION_URL", Value:"https://github.com/argoproj-labs/rollout-extension/releases/download/v0.3.6/extension.tar", ValueFrom:(*v1.EnvVarSource)(nil)}}
            	            	actual  : []v1.EnvVar(nil)
            	            	
            	            	Diff:
            	            	--- Expected
            	            	+++ Actual
            	            	@@ -1,8 +1,2 @@
            	            	-([]v1.EnvVar) (len=1) {
            	            	- (v1.EnvVar) {
            	            	-  Name: (string) (len=13) "EXTENSION_URL",
            	            	-  Value: (string) (len=89) "https://github.com/argoproj-labs/rollout-extension/releases/download/v0.3.6/extension.tar",
            	            	-  ValueFrom: (*v1.EnvVarSource)(<nil>)
            	            	- }
            	            	-}
            	            	+([]v1.EnvVar) <nil>
            	            	 
            	Test:       	Test_getRolloutInitContainer/when_running_in_gitops#01
            	Messages:   	Env check

@svghadi
Copy link
Collaborator

svghadi commented Nov 4, 2024

Please fix the unit test. Rest all looks good.

Signed-off-by: Anand Kumar Singh <[email protected]>
@anandrkskd
Copy link
Contributor Author

Hey Siddhesh, tests are passing now

Copy link
Collaborator

@svghadi svghadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@svghadi svghadi merged commit 56bb5db into argoproj-labs:master Nov 5, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants