Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade argocd version to 2.12.7 #1591

Conversation

ishitasequeira
Copy link
Collaborator

What type of PR is this?
/kind chore

What does this PR do / why we need it:
Upgrade ArgoCD version to 2.12.7

Signed-off-by: Ishita Sequeira <[email protected]>
@@ -1901,7 +1901,7 @@ spec:
fieldPath: metadata.annotations['olm.targetNamespaces']
- name: ENABLE_CONVERSION_WEBHOOK
value: "true"
image: quay.io/argoprojlabs/argocd-operator@sha256:405e7bde25affb7644c576a7f2d41ba30b88e2ef4f2f11945b920a33517895ce
image: quay.io/argoprojlabs/argocd-operator:v0.12.0
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

running make bundle seems to be automatically replacing the sha with tag. Do we see any issues with this update?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be fine. The CSV is updated with sha during operator release so shouldn't be a issue.

Signed-off-by: Ishita Sequeira <[email protected]>
Copy link
Collaborator

@svghadi svghadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@ishitasequeira ishitasequeira merged commit 855ecf2 into argoproj-labs:release-0.12 Nov 6, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants