Skip to content

test[#3]: add unittests for controllers #13

test[#3]: add unittests for controllers

test[#3]: add unittests for controllers #13

Triggered via pull request September 3, 2024 22:00
Status Failure
Total duration 3m 43s
Artifacts

golangci-lint.yaml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

3 errors and 1 warning
lint: internal/controller/testing.go#L349
`addFinalizerRole` - `finalizer` always receives `rbacoperatorv1alpha1.ArgoCDRoleFinalizerName` (`"role.rbac-operator.argoproj-labs.io"`) (unparam)
lint: internal/controller/testing.go#L368
`addFinalizerRoleBinding` - `finalizer` always receives `rbacoperatorv1alpha1.ArgoCDRoleBindingFinalizerName` (`"rolebinding.rbac-operator.argoproj-labs.io"`) (unparam)
lint
issues found
lint
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744, actions/setup-go@93397bea11091df50f3d7e59dc26a7711a8bcfbe, golangci/golangci-lint-action@3a919529898de77ec3da873e3063ca4b10e7f5cc. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/