-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented first usable version of the RBAC Operator #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, it seems like you have used the latest version of https://github.com/kubernetes-sigs/kubebuilder. However, I think the controller might try to do too much already. Can we limit the first version to manage policy.*.csv
keys only in configurable namespaces? This seems to be the main use case.
On another note, @sbeginCoveo @ggkhrmv if you want to discuss on the CNCF Slack, just send me a DM. I would like to have a chat to understand why this operator is a must for you. In almost all ArgoCD deployments I have come across, the global rbac policy configuration don't change often. Usually, it is the policies in the AppProject resource that are harder to define and manage. So I am struggling to grasp the long-term value of this operator, even though it is a nicer way to write the policies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing too deep to address, well done implementing the bindings reconciler
Great job giving users feedback though the status 🚀 That's really awesome
I'm gonna give it a spin on my cluster
Signed-off-by: Georgy Khromov <[email protected]>
a7d8233
to
2863151
Compare
Signed-off-by: Georgy Khromov <[email protected]>
Signed-off-by: Georgy Khromov <[email protected]>
Signed-off-by: Georgy Khromov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a minor comment.
LGTM regardless
Signed-off-by: Georgy Khromov <[email protected]>
The first version of the RBAC Operator has been implemented. The
make deploy
command doesn't work yet, since I couldn't push the docker image to the repo.To run the controller locally: