Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support azure china cloud vault backend endpoint #672

Open
harshktpa opened this issue Oct 28, 2024 · 0 comments · May be fixed by #673
Open

support azure china cloud vault backend endpoint #672

harshktpa opened this issue Oct 28, 2024 · 0 comments · May be fixed by #673

Comments

@harshktpa
Copy link

Is your feature request related to a problem? Please describe.
The current implementation of the Azure Key Vault backend only supports the standard Azure environment, which means that users working in Azure China cannot seamlessly access their secrets. This limitation creates friction for users who need to operate in both environments.

Describe the solution you'd like
I would like to enhance the Azure Key Vault backend to support dynamic vault URL generation based on the cloud environment. Specifically, when the AVP_AZ_CLOUD_NAME environment variable is set to azurechina, the backend should use the appropriate URL format (i.e., https://.vault.azure.cn) for accessing secrets.

Describe alternatives you've considered
I considered implementing a separate backend specifically for Azure China, but this would lead to code duplication and maintenance challenges.

Additional context
This feature is critical for organizations that operate in multiple Azure environments, especially those that have compliance or operational requirements to store and manage secrets in Azure China.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant