Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(azure-china): support azure china vault backend endpoint #673

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

harshktpa
Copy link

Description

This PR introduces modifications to the Azure Key Vault backend to support Azure China. It enhances the GetSecrets and GetIndividualSecret methods to dynamically adjust the vault URL based on the environment specified in the AVP_AZ_CLOUD_NAME environment variable.

Fixes: #672 (support azure china cloud vault backend endpoint)

Checklist

Please make sure that your PR fulfills the following requirements:

  • Reviewed the guidelines for contributing to this repository
  • The commit message follows the Conventional Commits Guidelines.
  • Tests for the changes have been updated
  • Are you adding dependencies? If so, please run go mod tidy -compat=1.22.7 to ensure only the minimum is pulled in.
  • Docs have been added / updated
  • Optional. My organization is added to USERS.md.

Type of Change

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

Other information

Other information
These changes allow the Azure Key Vault backend to function correctly in both standard Azure and Azure China environments by using the AVP_AZ_CLOUD_NAME environment variable. The logic for constructing the vault URL is updated, and the methods now handle secret retrieval based on the specified azure cloud environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support azure china cloud vault backend endpoint
1 participant