-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable templating keys with vault secrets #510
base: main
Are you sure you want to change the base?
Conversation
@omrishiv Thanks for this PR. Things look good after some manual testing. Can you add a couple tests using inline and annotation, combining keys and values being replaced. |
Thanks for the quick review; I added the tests |
Signed-off-by: Omri Shiv <[email protected]>
Signed-off-by: Omri Shiv <[email protected]>
Hi @werne2j do the tests look ok? |
I will take a close look later this week. Could you also add to the fixtures, specifically the nonempty directory and the outputs, in order to run through the generate tests https://github.com/argoproj-labs/argocd-vault-plugin/blob/main/cmd/generate_test.go |
Signed-off-by: Omri Shiv <[email protected]>
I added the fixtures to test and caught a case where |
Signed-off-by: Omri Shiv <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #510 +/- ##
==========================================
+ Coverage 75.38% 75.48% +0.10%
==========================================
Files 25 25
Lines 1694 1701 +7
==========================================
+ Hits 1277 1284 +7
Misses 323 323
Partials 94 94
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@werne2j gentle nudge if this looks good. Thanks! |
@werne2j bumping again please |
Description
This commit allows the keys to be templated from secrets in addition to the values.
Fixes: #171
Checklist
Please make sure that your PR fulfills the following requirements:
go mod tidy -compat=1.17
to ensure only the minimum is pulled in.Type of Change
Other information
Allows templating the keys