Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add quay.io prefix, since docker hub image is obsolete #623

Closed
wants to merge 2 commits into from

Conversation

bcopy
Copy link

@bcopy bcopy commented Mar 26, 2024

Docker hub image is 7 months old and refers to inexistant ubuntu package repositories, failing the code example.

Description

Update the FROM image to the official upstream argocd image.

Checklist

Please make sure that your PR fulfills the following requirements:

  • Reviewed the guidelines for contributing to this repository
  • The commit message follows the Conventional Commits Guidelines.
  • Tests for the changes have been updated
  • Are you adding dependencies? If so, please run go mod tidy -compat=1.21 to ensure only the minimum is pulled in.
  • Docs have been added / updated
  • Optional. My organization is added to USERS.md.

Type of Change

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

Other information

Docker hub image is 7 months old and refers to inexistant ubuntu package repositories, failing the code example
@werne2j
Copy link
Member

werne2j commented Apr 15, 2024

@bcopy please rebase and sign off on the commit when you have a chance

@bcopy
Copy link
Author

bcopy commented May 15, 2024

@werne2j sorry, not sure what you mean by "sign off"

@bcopy
Copy link
Author

bcopy commented May 15, 2024

I see one review approval is still needed

@werne2j
Copy link
Member

werne2j commented Sep 29, 2024

Duplicate #662

@werne2j werne2j closed this Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants