fix(ksm): handle duplicate secrets with the same uid #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbert229
force-pushed
the
bugfix/keeper-secrets-manager
branch
from
44df351
to
e585d00
Compare
robbert229
commented
Jul 8, 2024
Keeper Secrets Manager can return multiple records with the same uid. This is because KSM is now returning a secret for each time a secret is referenced. This breaks previous assumptions. Signed-off-by: John Rowley <[email protected]>
robbert229
force-pushed
the
bugfix/keeper-secrets-manager
branch
from
e585d00
to
f8ee3f4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #652 +/- ##
==========================================
+ Coverage 72.16% 73.64% +1.47%
==========================================
Files 26 26
Lines 1994 1586 -408
==========================================
- Hits 1439 1168 -271
+ Misses 458 314 -144
- Partials 97 104 +7 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeper Secrets Manager can return multiple records with the same uid. This is because KSM is now returning a secret for each time a secret is referenced. This breaks previous assumptions.
Description
Removing previous ksm sanity check ensuring a record is only returned once, and added supporting tests.
Checklist
Please make sure that your PR fulfills the following requirements:
go mod tidy -compat=1.21to ensure only the minimum is pulled in.Type of Change
Other information
I implemented the original keeper secrets manager functionality back in #468.