chore: add logging (#94)

* add logging Signed-off-by: Zach Aller <[email protected]> * add TODO note Signed-off-by: Zach Aller <[email protected]> --------- Signed-off-by: Zach Aller <[email protected]>
argoproj-labs · Oct 30, 2024 · 5e1e31e · 5e1e31e
1 parent 5c5b217
commit 5e1e31e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/internal/controller/promotionstrategy_controller.go b/internal/controller/promotionstrategy_controller.go
@@ -128,7 +128,8 @@ func (r *PromotionStrategyReconciler) SetupWithManager(mgr ctrl.Manager) error {
 
 	return ctrl.NewControllerManagedBy(mgr).
 		For(&promoterv1alpha1.PromotionStrategy{}, builder.WithPredicates(predicate.GenerationChangedPredicate{})).
-		Owns(&promoterv1alpha1.ChangeTransferPolicy{}).
+		// TODO: reduce reconciliation frequency by not reconciling when updates happen to CTPs, makes race easier to reason about
+		//Owns(&promoterv1alpha1.ChangeTransferPolicy{}).
 		Complete(r)
 }
 
@@ -468,7 +469,7 @@ func (r *PromotionStrategyReconciler) mergePullRequests(ctx context.Context, ps
 						return err
 					}
 					r.Recorder.Event(ps, "Normal", "PullRequestMerged", fmt.Sprintf("Pull Request %s merged", pullRequest.Name))
-					logger.V(4).Info("Merged pull request")
+					logger.Info("Merged pull request")
 				} else if pullRequest.Status.State == promoterv1alpha1.PullRequestOpen {
 					logger.Info("Pull request not ready to merge yet")
 				}

diff --git a/internal/git/git.go b/internal/git/git.go
@@ -192,6 +192,7 @@ func (g *GitOperations) GetShaTime(ctx context.Context, sha string) (v1.Time, er
 
 func (g *GitOperations) PromoteEnvironmentWithMerge(ctx context.Context, environmentBranch, environmentNextBranch string) error {
 	logger := log.FromContext(ctx)
+	logger.Info("Promoting environment with merge", "environmentBranch", environmentBranch, "environmentNextBranch", environmentNextBranch)
 
 	if g.pathLookup.Get(g.gap.GetGitHttpsRepoUrl(*g.gitRepo)+g.pathContext) == "" {
 		return fmt.Errorf("no repo path found")
@@ -230,7 +231,7 @@ func (g *GitOperations) PromoteEnvironmentWithMerge(ctx context.Context, environ
 		logger.Error(err, "could not git pull", "gitError", stderr)
 		return err
 	}
-	logger.V(4).Info("Pushed branch", "branch", environmentBranch)
+	logger.Info("Pushed branch", "branch", environmentBranch)
 
 	return nil
 }