Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Refactor tests #40

Merged
merged 3 commits into from
Sep 5, 2024
Merged

Conversation

zachaller
Copy link
Contributor

No description provided.

@zachaller zachaller changed the title Refactor tests chore: Refactor tests Sep 5, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 50.65%. Comparing base (e320f89) to head (1b202ef).

Files with missing lines Patch % Lines
internal/scms/github/pullrequest.go 0.00% 6 Missing ⚠️
internal/controller/commitstatus_controller.go 0.00% 1 Missing ⚠️
internal/controller/proposedcommit_controller.go 80.00% 1 Missing ⚠️
internal/scms/github/commit_status.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
+ Coverage   45.39%   50.65%   +5.26%     
==========================================
  Files          15       15              
  Lines        1064     1066       +2     
==========================================
+ Hits          483      540      +57     
+ Misses        494      452      -42     
+ Partials       87       74      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Zach Aller <[email protected]>
Signed-off-by: Zach Aller <[email protected]>
Signed-off-by: Zach Aller <[email protected]>
@zachaller zachaller marked this pull request as ready for review September 5, 2024 16:10
@zachaller zachaller merged commit 78ad11f into argoproj-labs:main Sep 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants