Skip to content

Commit

Permalink
fix setting labels twice in gordian transform function (#26)
Browse files Browse the repository at this point in the history
Co-authored-by: Etienne Grignon <[email protected]>
  • Loading branch information
sharpyy and etiennegrignon-intuit authored Jun 23, 2020
1 parent dce7eb6 commit 0bdc13c
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com),
and this project adheres to [Semantic Versioning](https://semver.org).

## [2.1.1] - 2020-06-23
### Fixed
- Fixed setting the labels twice when releasing 2.1.0

## [2.1.0] - 2020-06-23
### Added
- New optional flag to pass a description to the PR created by gordian.
Expand Down
1 change: 0 additions & 1 deletion gordian/gordian.py
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,6 @@ def transform(args, transformations, repositories, pr_description, pr_created_ca
if not args.dry_run:
try:
pull_request = repo.create_pr(args.pr_message, pr_description, args.target_branch, args.pr_labels)
pull_request.set_labels(*args.pr_labels)
pull_request_urls.append(pull_request.html_url)
if pr_created_callback is not None:
logger.debug(f'Calling post pr created callback with: {pull_request}, {repo.branch_name}')
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
setup_reqs = ['pytest', 'pytest-cov', 'pytest-runner', 'flake8']
setuptools.setup(
name="gordian",
version="2.1.0",
version="2.1.1",
author="Intuit",
author_email="[email protected]",
description="A tool to search and replace files in a Git repo",
Expand Down

0 comments on commit 0bdc13c

Please sign in to comment.