Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow path define on get files #42

Merged
merged 3 commits into from
Oct 24, 2023

Conversation

kaosx5s
Copy link
Collaborator

@kaosx5s kaosx5s commented May 16, 2023

Description

Thanks for contributing this Pull Request. Make sure that you send in this Pull Request to the master branch of this repository, add a brief description, and tag the relevant issue(s) and PR(s) below.

  • Relevant Issues :

  • What Changed and Why? :

  • Adds the ability to set a path when calling get_files() to support sparse checkouts, should resolve Fetching of all files #34

  • Type of change :

    • New feature
    • Bug fix for existing feature
    • Code quality improvement
    • Addition or Improvement of tests
    • Addition or Improvement of documentation
  • Other:

    • Add unit tests
    • Add documentation

@kaosx5s
Copy link
Collaborator Author

kaosx5s commented May 16, 2023

Waiting for #41 to be merged so I can rebase 😄

@kaosx5s kaosx5s force-pushed the allow-path-define-on-get-files branch from 828fc81 to a4a65bb Compare October 5, 2023 17:06
@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2023

Codecov Report

Merging #42 (d617a6b) into master (5924837) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #42   +/-   ##
=======================================
  Coverage   81.13%   81.13%           
=======================================
  Files          11       11           
  Lines         493      493           
  Branches       77       77           
=======================================
  Hits          400      400           
  Misses         76       76           
  Partials       17       17           
Files Coverage Δ
gordian/repo.py 78.36% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kaosx5s kaosx5s force-pushed the allow-path-define-on-get-files branch 3 times, most recently from 6ddc48d to 6260cea Compare October 5, 2023 17:19
@kaosx5s kaosx5s force-pushed the allow-path-define-on-get-files branch from 6260cea to 33da633 Compare October 5, 2023 17:22
@kaosx5s kaosx5s marked this pull request as ready for review October 5, 2023 17:25
Copy link
Collaborator

@coreycaverly coreycaverly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@kaosx5s kaosx5s merged commit 02e70bc into argoproj-labs:master Oct 24, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fetching of all files
3 participants