Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retry on timeout #54

Merged
merged 4 commits into from
May 23, 2024
Merged

Conversation

zejunintuit
Copy link
Contributor

@zejunintuit zejunintuit commented May 20, 2024

Description

Thanks for contributing this Pull Request. Make sure that you send in this Pull Request to the master branch of this repository, add a brief description, and tag the relevant issue(s) and PR(s) below.

  • Relevant Issues :
    When Autopilot gives timeout, it doesn't retry on timeout.

  • What Changed and Why? :
    Update gordian to handle github timeouts with retry

  • Type of change :

    • New feature
    • [Y] Bug fix for existing feature
    • Code quality improvement
    • Addition or Improvement of tests
    • Addition or Improvement of documentation
  • Other:

    • Add unit tests
    • Add documentation

@zejunintuit zejunintuit marked this pull request as draft May 21, 2024 16:07
@zejunintuit zejunintuit force-pushed the retry-on-timeout branch 2 times, most recently from b43862f to e6478a9 Compare May 22, 2024 23:02
@zejunintuit zejunintuit marked this pull request as ready for review May 22, 2024 23:03
tests/test_repo.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@kaosx5s kaosx5s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🌟

@kaosx5s kaosx5s merged commit 2e6be18 into argoproj-labs:master May 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants