Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing volume claim to user-container example #1242

Merged

Conversation

jeongukjae
Copy link
Collaborator

Pull Request Checklist

Description of PR
Following the volumes page in argo workflows document, updated user-container examples to have volumeClaimTemplates.

@jeongukjae jeongukjae self-assigned this Oct 17, 2024
@jeongukjae jeongukjae added type:skip-changelog A change that does not require a changelog entry semver:patch A change requiring a patch version bump type:task A general task labels Oct 17, 2024
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.9%. Comparing base (3266a5b) to head (186b5e7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1242   +/-   ##
=====================================
  Coverage   45.9%   45.9%           
=====================================
  Files         60      60           
  Lines       4082    4082           
  Branches     857     857           
=====================================
  Hits        1875    1875           
  Misses      2175    2175           
  Partials      32      32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeongukjae jeongukjae removed the type:skip-changelog A change that does not require a changelog entry label Oct 17, 2024
@sambhav sambhav enabled auto-merge (squash) October 21, 2024 09:54
@sambhav sambhav merged commit 30cb592 into argoproj-labs:main Oct 21, 2024
23 checks passed
@jeongukjae jeongukjae deleted the add-pvc-to-user-container-example branch October 21, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A change requiring a patch version bump type:task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example "user_container.py" doesn't work
2 participants