Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add argo lint on examples directory #1243

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add argo lint on examples directory #1243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b9fa96c
Add argo lint on examples directory
jeongukjae Oct 17, 2024
4353b3e
Update contributing.md
jeongukjae Oct 17, 2024
a0c37ed
Specify directories to lint
jeongukjae Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ help Showcase the help instructions for all the availa
init-files Generate the init-files of Hera
install-argo Install argo client
install Run poetry install with all extras for development
lint-argo Run argo lint command on examples folder and report problems (requires local argo cluster)
lint Run a `lint` process on Hera and report problems
models Generate all the Argo Workflows models
regenerate-example Regenerates the yaml for a single example, using EXAMPLE_FILENAME envvar
Expand Down
13 changes: 13 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,3 +176,16 @@ stop-argo: ## Stop the argo server
test-on-cluster: ## Run workflow tests (requires local argo cluster)
@(kubectl -n argo port-forward deployment/argo-server 2746:2746 &)
@poetry run python -m pytest tests/submissions -m on_cluster

.PHONY: lint-argo
lint-argo: ## Run argo lint command on examples folder and report problems (requires local argo cluster)
@(kubectl -n argo port-forward deployment/argo-server 2746:2746 &)
@argo lint --argo-server=localhost:2746 --insecure-skip-verify --token=dummy \
examples/workflows/artifacts \
examples/workflows/dags \
examples/workflows/experimental \
examples/workflows/loops \
examples/workflows/misc \
examples/workflows/scripts \
examples/workflows/steps \
examples/workflows/use_cases
Loading