Support Literal types in script runner #1249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alicederyn
force-pushed
the
input.only.literal.types
branch
from
9e88b0a
to
a6813e8
Compare
alicederyn
changed the title
alicederyn
added
semver:patch
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1249 +/- ##
=====================================
Coverage 86.2% 86.2%
=====================================
Files 60 60
Lines 4109 4113 +4
Branches 659 660 +1
=====================================
+ Hits 3543 3547 +4
Misses 393 393
Partials 173 173 ☔ View full report in Codecov by Sentry. |
alicederyn
force-pushed
the
input.only.literal.types
branch
6 times, most recently
from
3aa8505
to
3ee9ef3
Compare
alicederyn
commented
Oct 28, 2024
alicederyn
requested review from
flaviuvadan,
sambhav and
elliotgunton
as code owners
alicederyn
force-pushed
the
input.only.literal.types
branch
from
ab05641
to
eadeb61
Compare
Combine the two non-Pydantic paths of _get_inputs_from_callable into one using construct_io_from_annotation. This fixes a bug where the default was being verified as None for optional strings only if there was no IO annotation. Signed-off-by: Alice Purcell <[email protected]>
Signed-off-by: Alice Purcell <[email protected]>
Signed-off-by: Alice Purcell <[email protected]>
Signed-off-by: Alice Purcell <[email protected]>
jeongukjae
reviewed
Nov 5, 2024
Signed-off-by: Alice Purcell <[email protected]>
alicederyn
force-pushed
the
input.only.literal.types
branch
from
bbdcfb1
to
602ed78
Compare
This function only support setting the enum field, and it doesn't appear likely that we will want to set other fields in future, so make the name more specific. Additionally, add a docstring, and refactor the function to use the early-return pattern now adding other metadata is ruled out. Signed-off-by: Alice Purcell <[email protected]>
alicederyn
force-pushed
the
input.only.literal.types
branch
from
602ed78
to
dbb4a66
Compare
sambhav
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description of PR
Currently, the script runner does not support
Literaltypes, asorigin_type_issubtypedoes not special-case them, so_is_str_kwarg_ofdoes not return True.This PR adds supports for Literals to
origin_type_issubtype, and additionally copies their values from the annotation into theenumfield on input Parameters. It also combines two paths in_get_inputs_from_callableinto one by usingconstruct_io_from_annotationinstead of having a fallback branch ifget_workflow_annotationreturnsNone; this fixes a bug where the default was being verified as None for optional strings only if there was no IO annotation.