Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tolerate potential race condition in workflow create + wait #729

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

flaviuvadan
Copy link
Collaborator

Pull Request Checklist

Description of PR
See #721

CC @Abhishaike

Signed-off-by: Flaviu Vadan <[email protected]>
@flaviuvadan flaviuvadan added semver:patch A change requiring a patch version bump type:bug A general bug labels Jul 31, 2023
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #729 (65fb57c) into main (4bf33d0) will decrease coverage by 0.1%.
The diff coverage is 0.0%.

@@           Coverage Diff           @@
##            main    #729     +/-   ##
=======================================
- Coverage   77.7%   77.7%   -0.1%     
=======================================
  Files         45      45             
  Lines       3386    3387      +1     
  Branches     649     649             
=======================================
  Hits        2632    2632             
- Misses       573     574      +1     
  Partials     181     181             
Files Changed Coverage Δ
src/hera/workflows/workflow.py 79.6% <0.0%> (-0.4%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sambhav sambhav merged commit 154cab3 into main Jul 31, 2023
13 of 15 checks passed
@sambhav sambhav deleted the fv/sleep-before-get branch July 31, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A change requiring a patch version bump type:bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wait fails assertion due to race condition
2 participants