Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mypy default args issues in Workflow #918

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

mshatkhin23
Copy link
Contributor

@mshatkhin23 mshatkhin23 commented Jan 5, 2024

Pull Request Checklist

Description of PR
Fixes mypy linting issues with default args for mixin fields of arguments, metrics, volumes in workflow.py

Signed-off-by: Max Shatkhin <[email protected]>
@sambhav sambhav enabled auto-merge (squash) January 5, 2024 15:55
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (76660e7) 80.3% compared to head (9520783) 80.3%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #918   +/-   ##
=====================================
  Coverage   80.3%   80.3%           
=====================================
  Files         49      49           
  Lines       3833    3833           
  Branches     779     779           
=====================================
  Hits        3081    3081           
  Misses       557     557           
  Partials     195     195           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sambhav sambhav added semver:patch A change requiring a patch version bump type:bug A general bug labels Jan 5, 2024
@sambhav sambhav merged commit ecd0c70 into argoproj-labs:main Jan 5, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A change requiring a patch version bump type:bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants