fix: only terminate sidecars if the main container exit with code 0

argoproj-labs · May 18, 2021 · 3089119 · 3089119
1 parent 6dc28a2
commit 3089119
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/manager/controllers/step_controller.go b/manager/controllers/step_controller.go
@@ -188,7 +188,7 @@ func (r *StepReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.
 			// if the main container has terminated, kill all sidecars
 			mainCtrTerminated := false
 			for _, s := range pod.Status.ContainerStatuses {
-				mainCtrTerminated = mainCtrTerminated || (s.Name == dfv1.CtrMain && s.State.Terminated != nil)
+				mainCtrTerminated = mainCtrTerminated || (s.Name == dfv1.CtrMain && s.State.Terminated != nil && s.State.Terminated.ExitCode == 0)
 			}
 			log.Info("pod", "name", pod.Name, "phase", phase, "message", message, "mainCtrTerminated", mainCtrTerminated)
 			if mainCtrTerminated {