fix: change Kafka to use stats for pending

argoproj-labs · Oct 2, 2021 · 647d0a6 · 647d0a6
1 parent dc03e6c
commit 647d0a6
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 8 deletions.
diff --git a/test/kafka-stress/kafka_stress_test.go b/test/kafka-stress/kafka_stress_test.go
@@ -53,8 +53,6 @@ func TestKafkaSourceStress(t *testing.T) {
 
 	defer StartTPSReporter(t, "main", prefix, n)()
 	go PumpKafkaTopic(topic, n, prefix, Params.MessageSize)
-	WaitForPending()
-	WaitForNothingPending()
 	WaitForTotalSunkMessages(n, Params.Timeout)
 }
 

diff --git a/test/metric.go b/test/metric.go
@@ -18,10 +18,6 @@ func WaitForPending() {
 	ExpectMetric("sources_pending", Gt(0))
 }
 
-func WaitForNothingPending() {
-	ExpectMetric("sources_pending", Eq(0))
-}
-
 func WaitForTotalSourceMessages(v int) {
 	ExpectMetric("sources_total", Eq(float64(v)))
 }

diff --git a/test/stan-stress/stan_stress_test.go b/test/stan-stress/stan_stress_test.go
@@ -52,7 +52,6 @@ func TestStanSourceStress(t *testing.T) {
 	defer StartTPSReporter(t, "main", prefix, n)()
 
 	go PumpSTANSubject(longSubject, n, prefix, Params.MessageSize)
-	WaitForPending()
 	WaitForTotalSunkMessages(n, Params.Timeout)
 }
 

diff --git a/test/stan-stress/test-results.json b/test/stan-stress/test-results.json
@@ -14,7 +14,7 @@
   "TestStanSinkStress/replicas=3.tps": 300,
   "TestStanSinkStress/replicas=4.tps": 300,
   "TestStanSinkStress/replicas=5.tps": 350,
-  "TestStanSourceStress/.tps": 1650,
+  "TestStanSourceStress/.tps": 1150,
   "TestStanSourceStress/N=10,messageSize=100.tps": 850,
   "TestStanSourceStress/N=10,messageSize=1000.tps": 400,
   "TestStanSourceStress/currentContext=gke_jesse-sb_us-central1-c_dataflow-test,N=10,messageSize=5000000.tps": 40300,