fix: correct mis-reporting of missing

argoproj-labs · Sep 28, 2021 · ebf38e6 · ebf38e6
1 parent 7e5ce44
commit ebf38e6
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/runner/sidecar/monitor/impl.go b/runner/sidecar/monitor/impl.go
@@ -85,9 +85,8 @@ func (i *impl) Accept(ctx context.Context, sourceName, sourceURN string, partiti
 	}
 	if offset > expectedOffset {
 		missingCounter.WithLabelValues(sourceName).Inc()
-	} else {
-		i.db[key] = offset
 	}
+	i.db[key] = offset
 	return true, nil
 }
 

diff --git a/runner/sidecar/monitor/impl_test.go b/runner/sidecar/monitor/impl_test.go
@@ -55,7 +55,7 @@ func Test_impl_Accept(t *testing.T) {
 	})
 	thirtyDays := time.Hour * 24 * 30
 	rdb.On("Set", ctx, "my-pl/my-step/my-urn/1/offset", int64(1), thirtyDays).Return(nil)
-	rdb.On("Set", ctx, "my-pl/my-step/my-urn/2/offset", int64(2), thirtyDays).Return(nil)
+	rdb.On("Set", ctx, "my-pl/my-step/my-urn/2/offset", int64(4), thirtyDays).Return(nil)
 	t.Run("CommitOffsets", func(t *testing.T) {
 		i.commitOffsets(ctx)
 	})