feat: support multiple routes per rollout

[svrakitin]

Closes #33

Introduces httpRoutes and tcpRoutes fields to plugin config, which allows us to reference multiple HTTPRoute and TCPRoute resources.

Given following routes:

apiVersion: gateway.networking.k8s.io/v1beta1
kind: HTTPRoute
metadata:
  name: first-route
spec:
  parentRefs:
    - name: gateway
  rules:
  - matches:
    - path:
        type: PathPrefix
        value: /first
    backendRefs:
    - name: argo-rollouts-stable-service
      kind: Service
      port: 80
    - name: argo-rollouts-canary-service
      kind: Service
      port: 80
---
apiVersion: gateway.networking.k8s.io/v1beta1
kind: HTTPRoute
metadata:
  name: second-route
spec:
  parentRefs:
    - name: gateway
  rules:
  - matches:
    - path:
        type: PathPrefix
        value: /second  
    backendRefs:
    - name: argo-rollouts-stable-service
      kind: Service
      port: 80
    - name: argo-rollouts-canary-service
      kind: Service
      port: 80

We can configure the plugin to update weights for each referenced route. For example:

plugins:
  argoproj-labs/gatewayAPI:
    httpRoutes:
       - name: first-route
          useHeaderRoutes: true
       - name: second-route

useHeaderRoutes field indicates we will add header routes for this specific route or no

[Philipp-Plotnikov]

@svrakitin please ping me when you will resolve all comments. Thank you for contribution!

[svrakitin]

@Philipp-Plotnikov Made some changes

[Philipp-Plotnikov]

json.Unmarshal(rollout.Spec.Strategy.Canary.TrafficRouting.Plugins[PluginName], &gatewayAPIConfig)

[Philipp-Plotnikov]

@svrakitin Dont you think that

plugins:
  argoproj-labs/gatewayAPI:
    httpRoutes: 
      - first
      - second
     tcpRoutes:
...

Will be easier to use ? And also in so case we dont need additional structure in GatewayAPIConfig, right ? We will have seperate fields

HTTPRouteList []string 
TCPRouteList []string

[svrakitin]

I don't have a preference as long as it does the job. If you feel this makes more sense I'll update.

[Philipp-Plotnikov]

I don't have a preference as long as it does the job. If you feel this makes more sense I'll update.

Then, please update as it seems easier to use and less code

[svrakitin]

Done. Not sure that using separate fields makes it easier though.

[Philipp-Plotnikov]

Please update description to the PR to understand how to test this feature for users who wants to test it. I think it is very useful feature and somebody wants to test it not reading the code

[Philipp-Plotnikov]

Done. Not sure that using separate fields makes it easier though.

Code became cleaner and tcpRoutes and httpRoutes will be seperated and easier to find needing route in manifest

[Philipp-Plotnikov]

When you will finish please update me to be sure that it is ok, but I think it was last comments. We will wait a little bit on this week to give users a chance to run it locally and test it. After I or Kostis merge this PR and ping you here with congratulations )

[svrakitin]

Alright, I hope that's it. Everything else can be addressed by other PRs as pure cosmetics. Thanks.

[Philipp-Plotnikov]

@svrakitin great job!

[supersyn]

Hi all! I've built the plugin using this branch locally (run the make release command in the main folder), but when trying to use it I've stumbled upon the same issue as already reported here:

failed to get traffic router plugin argoproj-labs/gatewayAPI: unable to start plugin system: unable to get plugin client (argoproj-labs/gatewayAPI) for ping: exec: Stdout already set\n" error="<nil>"

The official v0.0.0-rc1 version of the plugin works without problems.

go version used for local build: go1.20.14 darwin/arm64

Built artifact I am using for testing.

I tried to reset the Argo Rollouts Controller deployment multiple times, delete the rollout, and reapply it again, but nothing helped.

Do you maybe have any idea what could be the issue here?

Thank you!

[Philipp-Plotnikov]

Hi @supersyn ! It seems because some process have been already using needing resources. Im using Vscode and in development in some cases I need to kill process manually to free resources to start new version of plugin. Did you check it ? Also I created PR with the fix for setHeaderRoute feature, you can try it, it would be great.
#37
Here you can find the example how to use it
#31

[svrakitin]

@Philipp-Plotnikov Recent changes in upstream introduced too many conflicts and I would appreciate help with resolving those as your team seem to have much more context and opinion on how to incorporate these changes. I will only be able to look at this again after Feb 24.

[kostis-codefresh]

@svrakitin We will resolve the conflicts since we introduced them. Sorry for the confusion.

[Philipp-Plotnikov]

@svrakitin it will be great if you will test it locally to be sure it is ok

[Philipp-Plotnikov]

@kostis-codefresh it seems PR is ready. I tested locally, it works fine. It will be great if someone will test it locally too.
To create local build, run in the root of repository:

make local-build

[Philipp-Plotnikov]

@svrakitin I think we will merge this PR on the following week if anyone will find bugs. As we have here a lot of features

[Philipp-Plotnikov]

@svrakitin our congratulations with contribution! Great job! Thank you!

[kostis-codefresh]

@svrakitin Documentation is now here https://rollouts-plugin-trafficrouter-gatewayapi.readthedocs.io/en/latest/features/multiple-routes/

Any feedback welcome