feat: return update errors #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tommy Chen <[email protected]>
tommy351
force-pushed
the
return-update-error
branch
from
070501d
to
bf3091a
Compare
pkg/plugin/httproute.go
Outdated
Comment on lines
54
to
59
| if err != nil { | ||
| msg := fmt.Sprintf(GatewayAPIUpdateError, httpRoute.GetName(), err) | ||
| r.LogCtx.Error(msg) | ||
| return pluginTypes.RpcError{ | ||
| ErrorString: err.Error(), | ||
| } |
There was a problem hiding this comment.
It seems we can delete this condition as if we will return error, argo rollouts controller will print message error
It will be great if you will check it and if it works then delete, please
Can you check it, please ?
There was a problem hiding this comment.
Updated in de5559d.
I checked it and Argo Rollouts prints logs when the plugin returns an error.
2024-04-29T09:31:40.670Z [DEBUG] plugin.gatewayAPI: time="2024-04-29T09:31:40Z" level=error msg="error updating Gateway API \"test\": Operation cannot be fulfilled on
httproutes.gateway.networking.k8s.io \"test\": the object has been modified; please apply your changes to the latest version and try again" plugin=trafficrouter
time="2024-04-29T09:31:40Z" level=warning msg="failed to set weight via plugin: Operation cannot be fulfilled on httproutes.gateway.networking.k8s.io \"test\": the obj
ect has been modified; please apply your changes to the latest version and try again" event_reason=TrafficRoutingError namespace=default rollout=test
Signed-off-by: Tommy Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the plugin prints the following error during an update. It might be better to return the error so it could be retried, or use patch instead of update.