Skip to content

Commit

Permalink
Ensure when alternatebackends is empty, canary weight should be 0
Browse files Browse the repository at this point in the history
Signed-off-by: Jonathan West <[email protected]>
  • Loading branch information
jgwest committed Jul 25, 2024
1 parent 8b4125a commit e993c28
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion tests/fixtures/route/route.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,12 @@ func HaveWeights(stableWeight, canaryWeight int32) matcher.GomegaMatcher {
return false
}

if len(route.Spec.AlternateBackends) == 1 && *route.Spec.AlternateBackends[0].Weight != canaryWeight {
if len(route.Spec.AlternateBackends) == 0 && canaryWeight != 0 {
// If alternate backend is empty, that is equivalent to a canary weight of 0, so we verify here that canary weight is 0.
fmt.Printf("Canary weight mismatch: got %d, want %d\n", 0, canaryWeight)
return false

} else if len(route.Spec.AlternateBackends) == 1 && *route.Spec.AlternateBackends[0].Weight != canaryWeight {
fmt.Printf("Canary weight mismatch: got %d, want %d\n", *route.Spec.AlternateBackends[0].Weight, canaryWeight)
return false
}
Expand Down

0 comments on commit e993c28

Please sign in to comment.