Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use canary service name in alternate backend #7

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

chetan-rns
Copy link
Collaborator

Currently, we use the route's alternate backend to configure the canary service. However, the plugin updates the alternate backend with the route name instead of the canary service name.

Copy link
Member

@jgwest jgwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @chetan-rns!

@jgwest jgwest merged commit 6c4e773 into argoproj-labs:main Mar 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants