Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e tests to verify plugin functionality #9

Merged
merged 3 commits into from
Mar 26, 2024

Conversation

chetan-rns
Copy link
Collaborator

@chetan-rns chetan-rns commented Mar 14, 2024

  • Add e2e tests using Ginkgo to verify the functionality of the Route plugin.
  • Add reusable fixtures
  • Add a script that will configure the plugin and run e2e tests
  • Update the go.mod to accommodate the OpenShift and the Rollouts package

Testing:

  1. Login to an OCP cluster.
  2. Make sure you have the argo-rollouts repository locally.
  3. Run the e2e test inside the rollouts-plugin-trafficrouter-openshift repository
$ ./hack/run-e2e-local.sh <ARGO_ROLLOUTS_PATH>

Fixes: #5

Signed-off-by: Chetan Banavikalmutt <[email protected]>
@chetan-rns
Copy link
Collaborator Author

@jgwest I've disabled the VCS stamping to fix the gosec error. Let me know if this workaround is okay. I suspect it has something to do with how git is configured when running gosec inside a container.

 GOFLAGS: -buildvcs=false

Copy link
Member

@jgwest jgwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @chetan-rns!

@jgwest jgwest merged commit 7aafe37 into argoproj-labs:main Mar 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate Ginkgo-based E2E test fixture and add E2E tests
2 participants