Allow blank Group on cluster resource [white|black]list (#258)

argoproj-labs · Apr 21, 2023 · 50f550a · 50f550a
1 parent 274c425
commit 50f550a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/argocd/resource_argocd_project_test.go b/argocd/resource_argocd_project_test.go
@@ -281,6 +281,14 @@ resource "argocd_project" "simple" {
       group = "rbac.authorization.k8s.io"
       kind  = "ClusterRole"
     }
+    cluster_resource_whitelist {
+      group = ""
+      kind  = "Namespace"
+    }
+    cluster_resource_blacklist {
+      group = ""
+      kind  = "ResourceQuota"
+    }
     cluster_resource_blacklist {
       group = "*"
       kind  = "*"

diff --git a/argocd/validators.go b/argocd/validators.go
@@ -73,9 +73,6 @@ func validateRoleName(value interface{}, key string) (ws []string, es []error) {
 
 func validateGroupName(value interface{}, key string) (ws []string, es []error) {
 	v := value.(string)
-	if strings.TrimSpace(v) == "" {
-		es = append(es, fmt.Errorf("%s: group '%s' is empty", key, v))
-	}
 
 	invalidChars := regexp.MustCompile("[,\n\r\t]")
 	if invalidChars.MatchString(v) {