Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify (and improve) testing reliability #440

Open
mkilchhofer opened this issue Oct 3, 2024 · 4 comments
Open

Clarify (and improve) testing reliability #440

mkilchhofer opened this issue Oct 3, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@mkilchhofer
Copy link
Collaborator

We should have a look into multiple parts of testing:

  • Acceptance tests sometimes fail (relatively often)
  • Against what versions of Argo CD should we test (currently we test against EOL versions of Argo CD)
  • internal/provider/data_source_application_test.go why do we specify a version constraint here? Can we remove it?
  • ..? (list not complete)
@onematchfox
Copy link
Collaborator

onematchfox commented Oct 3, 2024

Against what versions of Argo CD should we test (currently we test against EOL versions of Argo CD)

Per https://github.com/argoproj-labs/terraform-provider-argocd?tab=readme-ov-file#compatibility-promise this should be (yes, the test config is out of date 😄):

This provider is compatible with at least the last 2 minor releases of ArgoCD (e.g, ranging from 1.(n).m, to 1.(n-1).0, where n is the latest available minor version).

internal/provider/data_source_application_test.go why do we specify a version constraint here? Can we remove it?

I'll need to rack my brain/go through old commit history on this one. There was a reason but I can't for the life of me remember why off the top of my head.

@the-technat
Copy link
Collaborator

the-technat commented Oct 3, 2024

This provider is compatible with at least the last 2 minor releases of ArgoCD (e.g, ranging from 1.(n).m, to 1.(n-1).0, where n is the latest available minor version).

So for my understanding, this would currently be 2.12 and 2.11?

@onematchfox
Copy link
Collaborator

So for my understanding, this would currently be 2.12 and 2.11?

Correct. That's been the "promise" until now. Although, generally we would test the last 3 versions via the config here.

@the-technat
Copy link
Collaborator

I think we should also add different Terraform versions to our test matrix, ensuring it works when not using the latest Terraform version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants