test: Make acceptance tests happy again #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Maurer <[email protected]>
mkilchhofer
requested review from
onematchfox,
blakepettersson,
oboukili and
the-technat
mkilchhofer
changed the title
mkilchhofer
changed the title
onematchfox
approved these changes
Oct 3, 2024
| @@ -16,7 +16,7 @@ func TestAccArgoCDApplicationDataSource(t *testing.T) { | |||
| ExternalProviders: map[string]resource.ExternalProvider{ | |||
| "argocd": { | |||
| VersionConstraint: "~> 5.0", | |||
There was a problem hiding this comment.
Shouldn't the VersionConstraint be "~> 6.2.0" (or even "~> 7.0")?
There was a problem hiding this comment.
I did not want to touch any functionality/testing logic yet. Unsure why we had ~> 5.0 here. Maybe we should completely remove the version constriant?
There was a problem hiding this comment.
Created a follow-up issue for this:
the-technat
approved these changes
Oct 3, 2024
blakepettersson
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes failing acceptance tests in (draft) PR over here: