-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Kustomize patches to argocd_application
#360
base: main
Are you sure you want to change the base?
Add support for Kustomize patches to argocd_application
#360
Conversation
this patch feature was introduced in ArgoCD v2.9.0. However, the remaining environments are encountering failures as the system persistently attempts to add attributes to the state. Is there any example or method to limit that argument to versions above v2.9.0? (I am a complete newcomer to Terraform providers and Golang.) |
Hey, Thanks for this PR. #357 also attempts to upgrade the version of the ArgoCD module used here. However, there are issues with the latest version that will need to be handled. Will look at that PR first and then we can hopefully just rebase this on top of that changeset. |
This pr is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Not stale |
This pr is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Not stale |
This pr is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Not stale |
This pr is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Not stale |
... |
This pr is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
... |
This pr is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
... |
Signed-off-by: chidambaram27 <[email protected]>
…baram27/terraform-provider-argocd into feature/kustomize-patches
Hi @onematchfox , just wanna check if this PR still valid .. I totally missed it. Let me know if any changes need |
…baram27/terraform-provider-argocd into feature/kustomize-patches Signed-off-by: chidambaram27 <[email protected]>
…baram27/terraform-provider-argocd into feature/kustomize-patches
This pr is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
. |
Hi @chidambaram27 thank you for your contribution! We rebased your branch against the current codebase and reviewed the changes. One thing left is the DCO bot complaining about unsigned commits, would you mind verifying that all your commits include a |
Closes #356