add finalizers

[KyriosGN0]

i have added finalizers as a medata element (used the same implementation that was in the application resource)
closes #391

[github-actions]

This pr is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 10 days.

[KyriosGN0]

not stale

[onematchfox]

Slowly trying to make my way through open PRs. Thanks for your patience.

[onematchfox]

@KyriosGN0, quick update - I'm afraid implementing this isn't as simple as it may seem. There is a bunch of discussion/history contained in #224 that you may want to read through. In essence though, the finalizers field is something that could well be mutated by other resources within the cluster and so tracking this state within Terraform could well lead to Terraform overwriting/deleting things it shouldn't. This is also an issue with annotations for example (see #173). At the moment I'm not sure what the correct way forward here. At the very least we would need to ensure that the provider only own and track the finalizer(s) on the given Application (or Project, Cluster, etc) in order not to overwrite/delete any finalizers that haven't been explicitly set. However, doing this may be is tricky - particularly in the case of the removal of a finalizer (that was originally added via the terraform resource).

[github-actions]

This pr is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 10 days.

[onematchfox]

Keep for now. Could be worth exploring how the Kubernetes provider handles annotations.

[KyriosGN0]

@onematchfox i've read a bit the docs you sent, i'll give them another look cuz i really want to understand the issue

[github-actions]

This pr is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 10 days.