-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update argocd versions used for testing #443
Conversation
f05372c
to
18986c6
Compare
@@ -4,8 +4,8 @@ set -e | |||
|
|||
export PATH=$PATH:. | |||
|
|||
argocd_version=${ARGOCD_VERSION:-v2.8.13} | |||
k8s_version=${ARGOCD_KUBERNETES_VERSION:-v1.27.11} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: You may want to leave this one alone for the time being. It should generally match a version supported across all of the ArgoCD versions being tested.
https://argo-cd.readthedocs.io/en/stable/operator-manual/installation/#tested-versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx for the link, forgot that one. Changed the k8s version back to 1.27.11
as this is supported by Argo CD 2.10
, 2.11
and 2.12
.
7c28a1c
to
e255c3c
Compare
0ff773f
to
88ad857
Compare
Seems like Argo CD 2.12 is checking the repository:
Maybe we pick argo-helm? :) Update |
918da0a
to
1728a99
Compare
To fix the failing test I tried updating the main argo-cd module using So in the end I just ran: go get -u all
go mod edit -go=1.23
go mod tidy
go fix ./... And now we are up-to-date with almost all dependencies. But that means we might be too new with some. For example Doing all this, now golangci-lint in the current version fails, since we changed the go version 😕. |
a29b5bd
to
ca2acb8
Compare
ca2acb8
to
3fdda88
Compare
0e688e9
to
34f7dda
Compare
Signed-off-by: Nathanael Liechti <[email protected]>
34f7dda
to
342ce2c
Compare
Will be combined / merged into #464 |
An attempt to get back to our promise of supporting the latest 2 versions of Argo CD.
Might require bumping libraries to new versions as well.