Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update argocd versions used for testing #443

Closed
wants to merge 2 commits into from

Conversation

the-technat
Copy link
Collaborator

@the-technat the-technat commented Oct 4, 2024

An attempt to get back to our promise of supporting the latest 2 versions of Argo CD.

Might require bumping libraries to new versions as well.

@@ -4,8 +4,8 @@ set -e

export PATH=$PATH:.

argocd_version=${ARGOCD_VERSION:-v2.8.13}
k8s_version=${ARGOCD_KUBERNETES_VERSION:-v1.27.11}
Copy link
Collaborator

@onematchfox onematchfox Oct 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: You may want to leave this one alone for the time being. It should generally match a version supported across all of the ArgoCD versions being tested.

https://argo-cd.readthedocs.io/en/stable/operator-manual/installation/#tested-versions

Copy link
Collaborator Author

@the-technat the-technat Oct 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the link, forgot that one. Changed the k8s version back to 1.27.11 as this is supported by Argo CD 2.10, 2.11 and 2.12.

@the-technat the-technat force-pushed the feat/update-testing-versions branch 2 times, most recently from 7c28a1c to e255c3c Compare October 4, 2024 08:55
@the-technat the-technat changed the title feat: update argocd,k8s versions used for testing feat: update argocd versions used for testing Oct 4, 2024
@the-technat the-technat force-pushed the feat/update-testing-versions branch 3 times, most recently from 0ff773f to 88ad857 Compare October 4, 2024 09:33
@mkilchhofer
Copy link
Collaborator

mkilchhofer commented Oct 4, 2024

Seems like Argo CD 2.12 is checking the repository:

repo = "https://helm.nginx.com/stable"

    resource_argocd_repository_test.go:45: Step 3/3 error: Error running apply: exit status 1
        
        Error: failed to update repository https://helm.nginx.com/stable
        
          with argocd_repository.helm,
          on terraform_plugin_test.tf line 19, in resource "argocd_repository" "helm":
          19: resource "argocd_repository" "helm" {
        
        rpc error: code = NotFound desc = repo 'https://helm.nginx.com/stable' not
        found

Maybe we pick argo-helm? :)


Update
Strange: nginx repo exists: https://helm.nginx.com/stable/index.yaml

@mkilchhofer mkilchhofer linked an issue Oct 7, 2024 that may be closed by this pull request
@the-technat the-technat force-pushed the feat/update-testing-versions branch 3 times, most recently from 918da0a to 1728a99 Compare October 7, 2024 18:04
@the-technat
Copy link
Collaborator Author

the-technat commented Oct 7, 2024

To fix the failing test I tried updating the main argo-cd module using go get github.com/argoproj/argo-cd/[email protected]. But this in itself required other dependency updates.

So in the end I just ran:

go get -u all
go mod edit -go=1.23
go mod tidy
go fix ./...

And now we are up-to-date with almost all dependencies. But that means we might be too new with some. For example client-go is now using the v1.31.1 API schema of the K8s api.

Doing all this, now golangci-lint in the current version fails, since we changed the go version 😕.

@the-technat
Copy link
Collaborator Author

Will be combined / merged into #464

@the-technat the-technat deleted the feat/update-testing-versions branch October 17, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants