feat: add devcontainer #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-technat
commented
Oct 6, 2024
| }, | ||
| // https://github.com/devcontainers/features/tree/main/src/terraform | ||
| "ghcr.io/devcontainers/features/terraform:1": { | ||
| "version": "1.9.7" // omit for latest |
There was a problem hiding this comment.
Currently 1.9.7 is latest, but we could also omit the version at all or specify another one if there's a defined version we use in the project?
the-technat
force-pushed
the
feat/devcontainer
branch
4 times, most recently
from
bb8722c
to
7d54b51
Compare
the-technat
requested review from
oboukili,
onematchfox,
blakepettersson and
mkilchhofer
as code owners
mkilchhofer
approved these changes
Oct 8, 2024
Signed-off-by: Nathanael Liechti <[email protected]>
the-technat
force-pushed
the
feat/devcontainer
branch
from
7d54b51
to
cc0361f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
devcontainer.jsonfile to the repo declaring as code the development environment needed to develop this provider. See containers.dev for the standard.Helpful for users who want to quickly get started developing (e.g with Github Codespaces) or for users who like to offload their development workload to another machine using something like devpod.
I tested the image and did some coding using devpod, works like a charm. Might need slight updates in the future but I think It's a good v1 to work with.