Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation error with location.href ends with / #19093

Open
3 tasks done
KSH-code opened this issue Jul 17, 2024 · 3 comments · May be fixed by #19389
Open
3 tasks done

Navigation error with location.href ends with / #19093

KSH-code opened this issue Jul 17, 2024 · 3 comments · May be fixed by #19389
Labels
bug Something isn't working component:ui User interfaces bugs and enhancements type:bug

Comments

@KSH-code
Copy link

KSH-code commented Jul 17, 2024

Checklist:

  • I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
  • I've included steps to reproduce the bug.
  • I've pasted the output of argocd version.

Describe the bug

When I discover applications on like https://argocd.com/service/applications/, search applications and then click it.
But it is redirected to https://argocd.com/service/applications//{application-name}.
And an empty page is shown.

To Reproduce

  1. visit the page https://argocd.com/service/applications/
  2. search applications
  3. click any applicaiton
  4. empty page is shown

Expected behavior

  • redirect to an application page
@KSH-code KSH-code added the bug Something isn't working label Jul 17, 2024
@KSH-code
Copy link
Author

KSH-code commented Jul 17, 2024

it seems to be fixed on argo-ui. so I made an issue #19093 and also I made a pull request argoproj/argo-ui#565

can anyone provide me feedback please?
argo-ui looks like a stale project because the latest release 2.5.1 since 2 years ago.

@agilgur5
Copy link
Contributor

it seems to be fixed on argo-ui. so I made an issue #19093

Or argoproj/argo-ui#564 rather

Although looking at your PR, while that may solve the issue, it actually sounds like this may be improper usage of the goto function here (notably, Workflows, where I am a maintainer, does not have this problem). Removing any ./ usage in this repo should suffice. Here's a quick search of all navigation.goto usage in this repo (it may miss usage that uses other variable names however)

argo-ui looks like a stale project because the latest release 2.5.1 since 2 years ago.

It is deprecated, per argoproj/argo-ui#453, so very infrequently maintained. Releases are not currently used, so the commit history is more relevant, see also argoproj/argo-ui#562.

@KSH-code
Copy link
Author

Thanks.
I will take a look at your suggestion.

@KSH-code KSH-code linked a pull request Aug 6, 2024 that will close this issue
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component:ui User interfaces bugs and enhancements type:bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants