Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Allow Trailing Slashes #19093 #19389

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

KSH-code
Copy link

@KSH-code KSH-code commented Aug 6, 2024

If you are on the http://localhost:4000/applications/ and visiting an application page by searching applications, the empty page is shown.
and other redirection including end of trailing slash are too.

to solve above problem, trailing slashes should be allowed.

My first solution was to fix in argoproj/argo-ui#565. but argo-ui has been being in deprecation as far as I know. thus I will fix it by here.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

fixes #19093

Signed-off-by: Henry Kim <[email protected]>
Copy link

bunnyshell bot commented Aug 6, 2024

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

Copy link

bunnyshell bot commented Aug 6, 2024

✅ Preview Environment created on Bunnyshell but will not be auto-deployed

See: Environment Details

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@KSH-code KSH-code changed the title Remove trailing slash fix(ui): Remove trailing slash Aug 6, 2024
@KSH-code KSH-code changed the title fix(ui): Remove trailing slash fix(ui): Remove trailing slash #19093 Aug 6, 2024
@KSH-code
Copy link
Author

KSH-code commented Aug 6, 2024

/bns:deploy

@KSH-code KSH-code marked this pull request as ready for review August 6, 2024 06:54
@KSH-code KSH-code requested a review from a team as a code owner August 6, 2024 06:54
@KSH-code KSH-code changed the title fix(ui): Remove trailing slash #19093 fix(ui): Allow Trailing Slashes #19093 Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigation error with location.href ends with /
1 participant