Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump express from 4.19.2 to 4.20.0 in /ui (#19883) #19990

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

chengfang
Copy link
Contributor

@chengfang chengfang commented Sep 18, 2024

Bumps express from 4.19.2 to 4.20.0.


updated-dependencies:

  • dependency-name: express dependency-type: indirect ...

Due to some merge conflict in cherry-pick, the content of changes file (ui/yarn.lock) is generated from running yarn install. The real content of the delta is the same as the fix in release-2.11 branch.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Bumps [express](https://github.com/expressjs/express) from 4.19.2 to 4.20.0.
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/master/History.md)
- [Commits](expressjs/express@4.19.2...4.20.0)

---
updated-dependencies:
- dependency-name: express
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@chengfang chengfang requested a review from a team as a code owner September 18, 2024 20:33
@chengfang
Copy link
Contributor Author

chengfang commented Sep 18, 2024

the failure in "Integration tests / Check changes to generated code" seems an existing problem. It is also present in the previous merged PR in release-2.10 branch:
https://github.com/argoproj/argo-cd/actions/runs/10707803036/job/29688610993?pr=19266

@@ -2016,7 +2016,7 @@ spec:
               key: controller.ignore.normalizer.jq.timeout
               name: argocd-cmd-params-cm
               optional: true
-        image: quay.io/argoproj/argocd:v2.10.16
+        image: quay.io/argoproj/argocd:latest
         imagePullPolicy: Always
         name: argocd-application-controller
         ports:
Error: Process completed with exit code 1.

@ishitasequeira
Copy link
Member

Yes, @chengfang !! That's a known issue.

@ishitasequeira ishitasequeira merged commit 9865a8a into argoproj:release-2.10 Sep 18, 2024
18 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants