feat(ui): Requests info for Cpu and Mem added to Pod details #20637
+412
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Surajyadav <[email protected]>
🔴 Preview Environment stopped on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
Signed-off-by: Surajyadav <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20637 +/- ##
=========================================
Coverage ? 55.16%
=========================================
Files ? 324
Lines ? 55203
Branches ? 0
=========================================
Hits ? 30451
Misses ? 22143
Partials ? 2609 ☔ View full report in Codecov by Sentry. |
andrii-korotkov-verkada
approved these changes
Nov 7, 2024
| case 'Requests (CPU)': | ||
| return `${numericValue}m`; | ||
| case 'Requests (MEM)': { | ||
| return formatSize(numericValue / 1000); |
There was a problem hiding this comment.
Should this be / 1024?
| @@ -388,6 +410,29 @@ function formatMetric(name: ResourceName, val: number) { | |||
| return (val || '0') + 'm'; | |||
| } | |||
|
|
|||
| function claculatePodGrouprResquests(pods: Pod[]) { | |||
There was a problem hiding this comment.
Typos: claculatePodGrouprResquests -> calculatePodGroupsRequests
| const numericValue = parseInt(info.value, 10); //convert the string value to number | ||
| totalCpuMillicores += numericValue; | ||
| } | ||
| if (info.name === 'Requests (MEM)') { |
There was a problem hiding this comment.
Let's use constants for these.
|
|
||
| return { | ||
| cpuRequest: `${totalCpuMillicores}m`, | ||
| memoryRequests: `${formatSize(totalMemory / 1000)}` //changing it to bytes for formatSize |
There was a problem hiding this comment.
Maybe / 1024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue: #19457
1. Added the pod requests info to the Pod tooltip.
This will only show if the pod currently has some reserved requests (running pods with allocated requests).
When the pod completes successfully or fails with an error, the requests will be shown as 0 since they are no longer reserved.
(also if the resources aren't declared )
2. For the original request of adding the top/parent resource groups,
Added tests in info.go f and utils.test for scenerios of completed and failed state with allocated resources.
whole-pod-view-test.mp4
Checklist: