Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Upgrade helm to v3.16.2, dependency for #20287 #20650

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hawksight
Copy link

@hawksight hawksight commented Nov 4, 2024

Relates to #20287. Upgrading helm versions makes the helm flag --skip-schema-validation. This is required before it can be exposed to ArgoCD to be configured via the CRD.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Copy link

bunnyshell bot commented Nov 4, 2024

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

@hawksight hawksight changed the title feat: Upgrade helm to v3.16.2 feat: Upgrade helm to v3.16.2, dependency for #20287 Nov 4, 2024
Signed-off-by: Peter Fiddes <[email protected]>
Signed-off-by: Peter Fiddes <[email protected]>
@hawksight
Copy link
Author

I retried and can't see an obvious reason why the e2e tests are failing. I'm trying to run locally but hitting more issues getting that running. Reaching out in slack to try and get some experience eyes on what the issue(s) might be. (ref)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant