feat(appset): Provide additional parameter files to git generator - Fixes #20593 #20653
+1,661
−416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔴 Preview Environment stopped on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #20653 +/- ##
==========================================
+ Coverage 55.10% 55.13% +0.03%
==========================================
Files 324 324
Lines 55239 55319 +80
==========================================
+ Hits 30439 30500 +61
- Misses 22180 22198 +18
- Partials 2620 2621 +1 ☔ View full report in Codecov by Sentry. |
OpenGuidou
force-pushed
the
20593-gitgen
branch
3 times, most recently
from
0577c89
to
332728c
Compare
Signed-off-by: OpenGuidou <[email protected]>
OpenGuidou
force-pushed
the
20593-gitgen
branch
from
332728c
to
f8f5a0f
Compare
speedfl
reviewed
Nov 8, 2024
| A hierarchy occurs in case of collision betweens the parameters, as follows: | ||
|
|
||
| * Parameters are merged and overriden file by file, from top to bottom of the list provided | ||
| * When a file provided is a glob pattern, files are sorted by path and overrides occur in the sorted order. |
There was a problem hiding this comment.
I'm not 100% sure it's a good idea to provide globs here.
Forcing people to sort alphabetically can lead to error. I would rather enforce explicit path
What do you think @crenshaw-dev @ishitasequeira ?
speedfl
reviewed
Nov 8, 2024
| return nil, err | ||
| } | ||
|
|
||
| files, err := g.repos.GetFiles(context.TODO(), git.RepoURL, git.Revision, templatedPath, noRevisionCache, verifyCommit) |
There was a problem hiding this comment.
If we enforce explicit file, we may need to add a check before this call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20593
Checklist: