chore(deps): Update helm to v3.16.2

[reegnz]

Signed-off-by: Zoltán Reegn [email protected]

Should be cherry-picked onto release-2.13, release-2.12 and release-2.11 too as the older helm
version in 2.12 and 2.11 is flagged by security scanners as vulnerable. See #20026 for example.

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• The title of the PR conforms to the Toolchain Guide
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).
• My new feature complies with the feature status guidelines.
• I have added a brief description of why this PR is necessary and/or what this PR solves.
• Optional. My organization is added to USERS.md.
• Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

[bunnyshell]

❗ Preview Environment deployment failed on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

• 🚀 /bns:deploy to redeploy the environment
• ❌ /bns:delete to remove the environment

[reegnz]

I'm unsure if the test failures are related to the upgrade or not...

[crenshaw-dev]

Looks like "probably":

time="2024-11-06T13:28:38Z" level=error msg="../../dist/argocd app create test-helm-repo-diff-local --repo https://localhost:9444/argo-e2e/testdata.git/helm-repo/local --dest-server https://kubernetes.default.svc/ --helm-chart helm --project default --revision 1.0.0 --dest-namespace argocd-e2e--test-helm-repo-diff-local-nspmi --plaintext --server 127.0.0.1:8088 --auth-token *** --insecure failed exit status 20: time="2024-11-06T13:28:38Z" level=fatal msg="rpc error: code = InvalidArgument desc = application spec for test-helm-repo-diff-local is invalid: InvalidSpecError: Unable to generate manifests in : rpc error: code = Unknown desc = error fetching chart: failed to fetch chart: failed to get command args to log: helm pull --destination /tmp/bfd98ab7-4ba9-47b9-92a3-9748762cd11e --version 1.0.0 --username ****** --password ****** --repo https://localhost:9444/argo-e2e/testdata.git/helm-repo/local helm --ca-file /tmp/argo-e2e/app/config/tls/localhost --cert-file /tmp/3910697492 --key-file /tmp/3661335150 failed exit status 1: index.go:370: skipping loading invalid entry for chart \"helm\" \"1.0.0\" from https://localhost:9444/argo-e2e/testdata.git/helm-repo/local: validation: chart.metadata.name is required\nindex.go:370: skipping loading invalid entry for chart \"helm\" \"1.0.0\" from /tmp/helm1591399603/cache/helm/repository/u6MfWTwrhQbShg-e7Fklqv83kYo=-index.yaml: validation: chart.metadata.name is required\nError: chart \"helm\" version \"1.0.0\" not found in https://localhost:9444/argo-e2e/testdata.git/helm-repo/local repository"" execID=2dbaf

Seems the new helm binary might be more strict about invalid chart structure. Our tests probably just need to be updated to match Helm's expectations.

[reegnz]

I'll look into fixing the tests then.