Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Apply deletion permission checks when syncing with replace (#14161) #20720

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Apply deletion permission checks when syncing with replace (#14161) #20720

wants to merge 1 commit into from
+185 −2

Commits on Nov 8, 2024

  1. fix: Apply deletion permission checks when syncing with replace (argo… 

    …proj#14161)

Closes argoproj#14161

Sync with replace can be quite dangerous, but we currently allow it if the sync is allowed. Since sync with replace deletes resources and recreates them, it's reasonable to check deletion permissions for application and/or specific resources.

Let's cherry-pick this to 2.13.

Signed-off-by: Andrii Korotkov <[email protected]>
    @andrii-korotkov-verkada
    andrii-korotkov-verkada committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    0a8b1c2 View commit details
    Browse the repository at this point in the history