-
Notifications
You must be signed in to change notification settings - Fork 6.7k
feat(ui): configurable default theme #25807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
❗ Preview Environment deployment failed on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
a643d1a to
40feb83
Compare
Add support for setting a default theme (light, dark, auto) via the argocd-cm ConfigMap using the ui.defaulttheme key. The backend setting is exposed through the /api/v1/settings API and consumed by the UI on initialization, allowing operators to configure the default theme without requiring users to manually select it. Closes: argoproj#18524 Signed-off-by: pasteley <[email protected]>
40feb83 to
e9af294
Compare
|
/bns:deploy |
nitishfy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m not convinced this should live in the argocd-cm. The ConfigMap is primarily meant for instance-wide, admin-controlled configuration that affects how Argo CD behaves (auth, RBAC, repositories, feature flags, etc.). UI theme preference is fundamentally a user-facing, per-user concern, not a cluster- or instance-level one.
|
@nitishfy I can see why a “theme” setting might sound like a per-user preference at first glance, but in this PR it’s explicitly an operator-defined default that’s only used when no user preference exists. If a user selects a theme, that continues to take precedence. Also, So placing the default theme alongside existing UI customization knobs is consistent with current patterns. If you still think this shouldn’t live in |
|
Related: #25985 |
Add support for setting a default theme (light, dark, auto) via the argocd-cm ConfigMap using the ui.defaulttheme key. The backend setting is exposed through the /api/v1/settings API and consumed by the UI on initialization, allowing operators to configure the default theme without requiring users to manually select it.
Closes: #18524
Checklist: