Skip to content

Conversation

@nitishfy
Copy link
Member

@nitishfy nitishfy commented Jan 7, 2026

Related to #25877

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Title of the PR
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@nitishfy nitishfy requested a review from a team as a code owner January 7, 2026 10:16
@codecov
Copy link

codecov bot commented Jan 7, 2026

Codecov Report

❌ Patch coverage is 62.79070% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.82%. Comparing base (db2004f) to head (65abdd3).
⚠️ Report is 4 commits behind head on release-3.1.

Files with missing lines Patch % Lines
controller/appcontroller.go 61.76% 13 Missing ⚠️
controller/hydrator/hydrator.go 50.00% 1 Missing ⚠️
util/io/componsablefs.go 0.00% 1 Missing ⚠️
util/password/password.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-3.1   #25890      +/-   ##
===============================================
+ Coverage        61.81%   61.82%   +0.01%     
===============================================
  Files              347      347              
  Lines            48305    48308       +3     
===============================================
+ Hits             29859    29866       +7     
+ Misses           15559    15553       -6     
- Partials          2887     2889       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crenshaw-dev
Copy link
Member

@nitishfy do we also need to bump the go version in the GH workflows? I think that determines the go version used in tests/linting. So until we bump that it'll be difficult to judge whether the version bump "works."

Signed-off-by: nitishfy <[email protected]>
@nitishfy nitishfy requested a review from a team as a code owner January 7, 2026 15:20
@nitishfy
Copy link
Member Author

nitishfy commented Jan 7, 2026

@crenshaw-dev I forgot to update the go version in gh workflows. I've done it now. Fortunately, other PRs don't have a go upgrade required so we're good to go!

@crenshaw-dev
Copy link
Member

Looks like we also have to upgrade the linter, which may require making some changes to satisfy new lint rules. But we're almost there. At least tests all pass!

@nitishfy
Copy link
Member Author

nitishfy commented Jan 7, 2026

@crenshaw-dev how about now? :)

@crenshaw-dev
Copy link
Member

@nitishfy looks like the linter is still unhappy 0_o

Signed-off-by: nitishfy <[email protected]>
@nitishfy nitishfy force-pushed the nitish/fix-cve-3.1 branch from f75c94d to 6ec0a68 Compare January 8, 2026 11:47
@nitishfy
Copy link
Member Author

nitishfy commented Jan 8, 2026

The linter is happy now!

Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last small (I think) request, then LGTM!

@nitishfy nitishfy changed the title chore(cherry-pick-3.1): upgrade go to 1.25.5 and bump expr to v1.17.7 chore(cherry-pick-3.1): bump go to 1.25.5 and bump expr to v1.17.7 Jan 11, 2026
@nitishfy nitishfy requested a review from crenshaw-dev January 11, 2026 11:51
@crenshaw-dev crenshaw-dev merged commit f22ccc2 into argoproj:release-3.1 Jan 12, 2026
22 of 23 checks passed
@nitishfy nitishfy changed the title chore(cherry-pick-3.1): bump go to 1.25.5 and bump expr to v1.17.7 fix(CVEs - cherry-pick-3.1): bump go to 1.25.5 and bump expr to v1.17.7 Jan 12, 2026
@nitishfy nitishfy deleted the nitish/fix-cve-3.1 branch January 13, 2026 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants