-
Notifications
You must be signed in to change notification settings - Fork 6.7k
fix(CVEs - cherry-pick-3.1): bump go to 1.25.5 and bump expr to v1.17.7
#25890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(CVEs - cherry-pick-3.1): bump go to 1.25.5 and bump expr to v1.17.7
#25890
Conversation
Signed-off-by: nitishfy <[email protected]>
Signed-off-by: nitishfy <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-3.1 #25890 +/- ##
===============================================
+ Coverage 61.81% 61.82% +0.01%
===============================================
Files 347 347
Lines 48305 48308 +3
===============================================
+ Hits 29859 29866 +7
+ Misses 15559 15553 -6
- Partials 2887 2889 +2 ☔ View full report in Codecov by Sentry. |
|
@nitishfy do we also need to bump the go version in the GH workflows? I think that determines the go version used in tests/linting. So until we bump that it'll be difficult to judge whether the version bump "works." |
Signed-off-by: nitishfy <[email protected]>
|
@crenshaw-dev I forgot to update the go version in gh workflows. I've done it now. Fortunately, other PRs don't have a go upgrade required so we're good to go! |
|
Looks like we also have to upgrade the linter, which may require making some changes to satisfy new lint rules. But we're almost there. At least tests all pass! |
Signed-off-by: nitishfy <[email protected]>
|
@crenshaw-dev how about now? :) |
|
@nitishfy looks like the linter is still unhappy 0_o |
Signed-off-by: nitishfy <[email protected]>
f75c94d to
6ec0a68
Compare
|
The linter is happy now! |
crenshaw-dev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last small (I think) request, then LGTM!
Signed-off-by: nitishfy <[email protected]>
1.25.5 and bump expr to v1.17.71.25.5 and bump expr to v1.17.7
1.25.5 and bump expr to v1.17.71.25.5 and bump expr to v1.17.7
Related to #25877
Checklist: