Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(github): Migrate to renovate GH action #2520

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

mkilchhofer
Copy link
Member

@mkilchhofer mkilchhofer commented Feb 15, 2024

This is a working WIP to replace Renovate hosted app at (https://developer.mend.io/) with a self-hosted version via the official GitHub action renovatebot/github-action.

PR is to start a discussion whether we want to keep the existing approach introduced by @tico24 here:

Status quo

In my point of view it is a bit fragile to synchronize between an App and a GH action. Especially as soon as the GH action adds another commit to update the changelog, Renovate cannot update the PR anymore, otherwise the GH action needs to update the changelog again (unsure whether it works today).

grafik

Renovate as a GH action

When we use Renovate as an action, we talk about self-hosted. This ways we are then allowed to execute so-called postUpgradeTasks. Everything then is under full-control of Renovate.

grafik
Source: https://docs.renovatebot.com/configuration-options/#postupgradetasks

If we proceed

Things which are open to proceed:

  • Create a GitHub App at org level (argoproj) -> reach out to maintainers via Slack
    Grant same permissions as the official App from MEND

    permissions

  • Install the app into argo-helm -> Also via Slack
  • Add 1 secret to argo helm (GitHub App private key RENOVATE_APP_PRIVATE_KEY)
  • Add 1 variable to argo helm (GitHub App ID RENOVATE_APP_ID)

@mbevc1
Copy link
Collaborator

mbevc1 commented Feb 15, 2024

Seems reasonable to switch, but also no strong opinions here.

@mkilchhofer mkilchhofer changed the title [WIP] chore: Migrate to renovate GH action [WIP] chore(github): Migrate to renovate GH action Feb 18, 2024
@mkilchhofer mkilchhofer force-pushed the old_version branch 6 times, most recently from f6c529d to 59e90e8 Compare February 25, 2024 13:06
@terrytangyuan
Copy link
Member

Things which are open to proceed

Done.

@mkilchhofer mkilchhofer changed the title [WIP] chore(github): Migrate to renovate GH action chore(github): Migrate to renovate GH action Feb 29, 2024
@mkilchhofer mkilchhofer marked this pull request as ready for review February 29, 2024 18:50
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkilchhofer mkilchhofer merged commit e0f6a16 into argoproj:main Feb 29, 2024
7 checks passed
@mkilchhofer mkilchhofer deleted the old_version branch February 29, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants