Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(argo-cd): Generate crd from upstream #2614

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

DrFaust92
Copy link
Contributor

@DrFaust92 DrFaust92 commented Mar 29, 2024

Closes #2613

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

@DrFaust92 DrFaust92 changed the title Generate-crd Generate crd from upstream Mar 29, 2024
@DrFaust92
Copy link
Contributor Author

need to fix this to support the custom templating (annotations and if to enable crd) and this should be good. but i would love to get input from maintainer if this is a valid approach.

@jmeridth @pdrastil @yu-croco , what do you think?

@DrFaust92 DrFaust92 changed the title Generate crd from upstream feat(argo-cd): Generate crd from upstream Mar 29, 2024
@github-actions github-actions bot removed the size/L label Mar 29, 2024
Signed-off-by: drfaust92 <[email protected]>
Signed-off-by: drfaust92 <[email protected]>
Signed-off-by: drfaust92 <[email protected]>
Signed-off-by: drfaust92 <[email protected]>
Signed-off-by: drfaust92 <[email protected]>
@yu-croco
Copy link
Collaborator

yu-croco commented Apr 2, 2024

Hi @DrFaust92 , thank you for your PR.
IMO:

  • Auto generation of CRD sounds nice to me.
  • In addition to support .Values.crds.xxxx , it's also nice to run this script when Renovate bumps version. 👍

@mbevc1 @mkilchhofer@jmeridth @pdrastil @tico24
WDYT? 🙋

@pdrastil
Copy link
Member

pdrastil commented Apr 3, 2024

@yu-croco Sounds OK, however upstream do not have templating on CRD resources / additional conditional block we have. You can see removed sections in PR. In both cases auto-generation or manual sync I always have to modify these sections by hand.

@DrFaust92
Copy link
Contributor Author

@pdrastil I'll add logic to template this, just wanted to know if it's worth the effort in the first place 🤗

@pdrastil
Copy link
Member

pdrastil commented Apr 3, 2024

@DrFaust92 It is - my current process is doing diffs / manual copy & paste of spec based on upstream :)

@mkilchhofer
Copy link
Member

Maybe we need some yq logic to only copy over the CRD.spec?🤣

Copy link

github-actions bot commented Jun 3, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@yu-croco yu-croco added the on-hold Issues or Pull Requests with this label will never be considered stale label Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
argo-cd on-hold Issues or Pull Requests with this label will never be considered stale size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate CRD spec based on upstream tag, similar to kube-prometheus-stack helm chart
4 participants