-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(argo-cd): Generate crd from upstream #2614
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: drfaust92 <[email protected]>
Signed-off-by: drfaust92 <[email protected]>
Signed-off-by: drfaust92 <[email protected]>
Signed-off-by: drfaust92 <[email protected]>
Signed-off-by: drfaust92 <[email protected]>
Hi @DrFaust92 , thank you for your PR.
@mbevc1 @mkilchhofer@jmeridth @pdrastil @tico24 |
@yu-croco Sounds OK, however upstream do not have templating on CRD resources / additional conditional block we have. You can see removed sections in PR. In both cases auto-generation or manual sync I always have to modify these sections by hand. |
@pdrastil I'll add logic to template this, just wanted to know if it's worth the effort in the first place 🤗 |
@DrFaust92 It is - my current process is doing diffs / manual copy & paste of spec based on upstream :) |
Maybe we need some yq logic to only copy over the CRD.spec?🤣 |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Closes #2613
Checklist: