Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(argocd-image-updater): Add parameter to chose namespaced or clusterwide mode #2879

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat(argocd-image-updater): Add parameter to chose namespaced or clusterwide mode #2879

wants to merge 4 commits into from

Conversation

sribiere-jellysmack
Copy link

@sribiere-jellysmack sribiere-jellysmack commented Aug 13, 2024 •
edited
Loading

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

@sribiere-jellysmack
feat(argocd-image-updater): add a parameter to chose namespaced or cl…
8c5c88b 
…usterwide mode for AIU

Signed-off-by: Sebastien RIBIERE <[email protected]>
@sribiere-jellysmack
Copy link
Author

Related to argoproj-labs/argocd-image-updater#831

@mkilchhofer mkilchhofer added the awaiting-upstream Is waiting for a change upstream to be completed before it can be merged. label Aug 13, 2024
@sribiere-jellysmack
Copy link
Author

Any review please?

@yu-croco
Copy link
Collaborator

yu-croco commented Sep 4, 2024

Hi @sribiere-jellysmack ,
since argo-helm follows upstream and your PR ( argoproj-labs/argocd-image-updater#831 ) is not merged yet in upstream, we put awaiting-upstream label and waiting for it.
When the PR is merged in upstream and argo-image-updater bumps new version for it, we will review.

@mkilchhofer mkilchhofer changed the title feat(argocd-image-updater): add a parameter to chose namespaced or clusterwide mode for AIU feat(argocd-image-updater): Add parameter to chose namespaced or clusterwide mode Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkilchhofer mkilchhofer Awaiting requested review from mkilchhofer mkilchhofer is a code owner

@jmeridth jmeridth Awaiting requested review from jmeridth jmeridth is a code owner

@yu-croco yu-croco Awaiting requested review from yu-croco yu-croco is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
argocd-image-updater awaiting-upstream Is waiting for a change upstream to be completed before it can be merged. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sribiere-jellysmack @yu-croco @mkilchhofer