Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(trafficrouting): enable setHeaderRoute for plugin/contour #3014

Closed
wants to merge 3 commits into from

Conversation

izturn
Copy link
Contributor

@izturn izturn commented Sep 5, 2023

Signed-off-by: Gang Liu [email protected]
fix #3013

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@izturn izturn changed the title feat(plugin): enable setHeaderRoute for plugin/contour feat(trafficrouting): enable setHeaderRoute for plugin/contour Sep 5, 2023
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (2cf1aa1) 81.75% compared to head (8685e26) 81.76%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3014   +/-   ##
=======================================
  Coverage   81.75%   81.76%           
=======================================
  Files         134      134           
  Lines       20395    20404    +9     
=======================================
+ Hits        16674    16683    +9     
  Misses       2865     2865           
  Partials      856      856           
Files Changed Coverage Δ
pkg/apis/rollouts/validation/validation.go 95.68% <100.00%> (+0.11%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

Go Published Test Results

2 047 tests   2 047 ✔️  2m 40s ⏱️
   118 suites         0 💤
       1 files           0

Results for commit 8685e26.

♻️ This comment has been updated with latest results.

Signed-off-by: gang.liu <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

E2E Tests Published Test Results

    4 files      4 suites   3h 33m 6s ⏱️
102 tests   92 ✔️   6 💤   4
420 runs  384 ✔️ 24 💤 12

For more details on these failures, see this check.

Results for commit 8685e26.

♻️ This comment has been updated with latest results.

@izturn
Copy link
Contributor Author

izturn commented Sep 6, 2023

@zachaller PTAL

@sonarcloud
Copy link

sonarcloud bot commented Sep 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
6.4% 6.4% Duplication

@zachaller
Copy link
Collaborator

closing in favor of this: https://github.com/argoproj/argo-rollouts/pull/2898/files

@zachaller zachaller closed this Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable SetHeaderRoute for plugin argoproj-labs/contour
2 participants